Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/modules/libmar/src/mar_create.c#253-259

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

I don't understand how I would choose the reviewer for something like this. I just have to add the commit message and push. So far I have:
Bug 1862505 - Removed unnecessary else statement. r?reviewer
How would I determine the reviewer? From running hg log modules/libmar/src/mar_create.c it seems I should make it r=Ehsan. Is that what I do?

put my name, this is fine :)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #2)

put my name, this is fine :)

Sorry, so would I make it Bug 1862505 - Removed unnecessary else statement. r?Sylvestre Ledru [:Sylvestre]

(In reply to aaoblivion from comment #3)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #2)

put my name, this is fine :)

Sorry, so would I make it Bug 1862505 - Removed unnecessary else statement. r?Sylvestre Ledru [:Sylvestre]

edit: Nevermind I just used r=sylvestre

Comment on attachment 9365888 [details]
Bug 1862505 - removes the use of 'else' after 'return' r=nalexander

Revision D194900 was moved to bug 1862506. Setting attachment 9365888 [details] to obsolete.

I am really sorry for using the wrong bugzilla ID. It wont happen again. Sorry! how do i remove myself from assigned?

https://hg.mozilla.org/mozilla-central/rev/407939d190f9